Skip to content

Add socket manifest <lang> including scala as first lang #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 10, 2025
Merged

Conversation

pvdz
Copy link
Collaborator

@pvdz pvdz commented Feb 5, 2025

This will add a new command to the socket npm cli: socket manifest <language>, and the first language: socket manifest scala.

Naming is hard, I think manifest is most apt, short, and to the point: it creates a dependency manifest.

The command is meant to support things that we currently can't support server side (and also not supported through cyclone (cdxgen)) and which has to run on the client machine.

First candidate is Scala, sbt in particular. Since we can't easily find dependencies through static analysis and cyclone doesn't really support it properly, this socket manifest scala command would be a wrapper to generate a dependency manifest by levering the (almost guaranteed to exist) local sbt setup.

There's also a socket manifest auto which tries to detect the proper sub command to execute with default parameters.

  • tests (um)
  • do we want to do more with the resulting manifest or leave it like it is now?
    • we want to figure out the story of how to store these files so we can predictably pick them up through the github api and it must consider multiple languages per repo and mono-repo cases
  • somehow verify this is a good approach for actual projects (how?)
  • cleanup/formatting/whatevs
  • swap out exec for spawn
  • change sbom to manifest, unless a better name comes up
  • think a little harder on the output api, the file to commit to the repo for us to find through github api, what if monorepo, what if polyglot repo, what if multi build targets (dev/prod)
  • figure out issue with boolean flags still consuming cli args

@pvdz pvdz changed the title Add socket sbom command and socket sbom scala Add socket sbom <lang> including scala as first lang Feb 5, 2025
@pvdz pvdz changed the title Add socket sbom <lang> including scala as first lang Add socket manifest <lang> including scala as first lang Feb 6, 2025
@pvdz pvdz marked this pull request as ready for review February 7, 2025 15:50
@pvdz pvdz merged commit ccf21b4 into main Feb 10, 2025
15 checks passed
@pvdz pvdz deleted the add-sbom branch February 10, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants